Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated convbert.md to Korean #34599

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

ahnjj
Copy link
Contributor

@ahnjj ahnjj commented Nov 4, 2024

<!β€” PR의 제λͺ©μ€ "🌐 [i18n-KO] Translated <your_file>.md to Korean" 으둜 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€ β€”>

What does this PR do?

Translated the convbert.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (λ²ˆμ—­ λˆ„λ½/쀑볡 검사)
  • Grammar Check (λ§žμΆ€λ²• 검사)
  • Review or Add new terms to glossary (μš©μ–΄ 확인 및 μΆ”κ°€)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview둜 μ •μƒμž‘λ™ 확인)

Who can review? (Initial)

@ahnjj, @jun048098, @Jwaminju, @jeongiin, @chhaewxn, @yijun-lee

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@ahnjj ahnjj marked this pull request as ready for review November 4, 2024 13:36
Copy link
Contributor

@jun048098 jun048098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! λ²ˆμ—­ κ°μ‚¬ν•©λ‹ˆλ‹€

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 7bbc624 into huggingface:main Nov 5, 2024
9 checks passed
2015aroras pushed a commit to 2015aroras/transformers that referenced this pull request Nov 15, 2024
* docs: ko: convbert.md

* Update _toctree.yml

* feat: nmt draft
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* docs: ko: convbert.md

* Update _toctree.yml

* feat: nmt draft
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
* docs: ko: convbert.md

* Update _toctree.yml

* feat: nmt draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants