Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tensor + Embedding error in some cases when using SiglipVisionModel #33994

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

kaitolucifer
Copy link
Contributor

What does this PR do?

Fixes #33993

@kaitolucifer kaitolucifer changed the title Fix Tensor + Embedding error in some cases of SiglipVisionModel Fix Tensor + Embedding error in some cases when using SiglipVisionModel Oct 6, 2024
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ArthurZucker ArthurZucker merged commit e782e95 into huggingface:main Oct 7, 2024
11 of 13 checks passed
@ArthurZucker
Copy link
Collaborator

🤗

ArthurZucker pushed a commit that referenced this pull request Oct 7, 2024
…el (#33994)

Fix Tensor + Embedding error in some cases

Co-authored-by: kaitolucifer <[email protected]>
NielsRogge pushed a commit to NielsRogge/transformers that referenced this pull request Oct 21, 2024
…el (huggingface#33994)

Fix Tensor + Embedding error in some cases

Co-authored-by: kaitolucifer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error happens when using SiglipVisionModel.forward with interpolate_pos_encoding=True
2 participants