Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jinja as a requirement with the right version cutoff #31536

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

Rocketknight1
Copy link
Member

We (I) were lazy and didn't add Jinja as a requirement because it was already a requirement of torch. This PR finally makes it a requirement of transformers as well, and lets us set the right version cutoff so we can ensure we have the filters we need to render templates properly.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding

Let's just have a double check from @ydshieh to confirm if we need to add this anywhere else

Copy link
Contributor

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes Transformers.js CI ✅

@Rocketknight1
Copy link
Member Author

Merging this to make sure it's in time for the release, but @ydshieh feel free to let me know if there's anything else I need to add and I'll put it in a follow-up PR!

@Rocketknight1 Rocketknight1 merged commit 2d48202 into main Jun 24, 2024
23 checks passed
@Rocketknight1 Rocketknight1 deleted the add_jinja_requirement branch June 24, 2024 13:42
@ydshieh
Copy link
Collaborator

ydshieh commented Jun 24, 2024

@Rocketknight1 Is jinja necessary in some tests? Or it's just for some people including you when working with templates?

@Rocketknight1
Copy link
Member Author

@ydshieh there are chat template tests in test_tokenization_common and test_chat_template_utils

@ydshieh
Copy link
Collaborator

ydshieh commented Jun 24, 2024

In order to have this version being taking into account in our CI, we will have to this dependency being used in

  • for example, docker/torch-light.dockerfile so CircleCI could use it
  • also some docker files for GitHub Actions (daily CI for example)

If so far CI works well without what I suggest above, it's fine. We can take some actions once we need some changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants