-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct @is_flaky test decoration #31480
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for identifying this!
Let's trigger a CI that runs slow tests for a few models involved. I have put a label |
@ydshieh I triggered slow tests, but it seems like flash attention is not installed in CI (according to pip freeze output) -> tests were skipped: |
oh, right. Those flash attn tests will only run with One last thing could try is to use https://github.com/huggingface/transformers/actions/workflows/ssh-runner.yml Internal notion doc: https://www.notion.so/huggingface2/SSH-into-our-runners-d9c24de77d0843b2a308f28171106001 It's more a good chance to learn how to use this. Would you like to give it a try even it's somehow manual? For docker image, you will have to fill You will have to do (once inside the runner)
and
|
will merge after an approval from @amyeroberts (as a manual run inside the runner is done .) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing and running tests!
* Correct @is_flaky decorator
What does this PR do?
Some tests are marked with
@is_flaky
decorator without brackets, which leads to always passing the test even if an exception is always raised in the test.For example:
P.S. Fixing this may lead to failing flaky tests, but now these tests are just broken.
Who can review?
@ydshieh