Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload (daily) CI results to Hub #31168

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Upload (daily) CI results to Hub #31168

merged 7 commits into from
Jun 4, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented May 31, 2024

What does this PR do?

Let's start to upload the results to a Hub dataset hf-internal-testing/transformers_daily_ci and use this dataset to build a visualization dashboard 🚀 !

So far I take the advantage of the daily CI workflow run - upload directly from there instead of fetching the finished workflow run afterward.

I didn't change any format in the raw reports (but processed in the workflow), but I believe it contains everything required to perform visualization/analysis.

A dummy run gives hf-internal-testing/transformers_daily_ci

@ydshieh ydshieh requested a review from LysandreJik May 31, 2024 15:57
@@ -19,6 +19,8 @@ on:
required: true
type: string

env:
TRANSFORMERS_CI_RESULTS_UPLOAD_TOKEN: ${{ secrets.TRANSFORMERS_CI_RESULTS_UPLOAD_TOKEN }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new fine grained token with write access to hf-internal-testing/transformers_daily_ci

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Comment on lines +1160 to +1161
target_workflow = "huggingface/transformers/.github/workflows/self-scheduled-caller.yml@refs/heads/main"
is_scheduled_ci_run = os.environ.get("CI_WORKFLOW_REF") == target_workflow
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only upload the results for the runs triggered by the scheduled event .

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ydshieh
Copy link
Collaborator Author

ydshieh commented Jun 3, 2024

Thanks for the review. I will merge once I applied the same changes to

utils/notification_service_quantization.py

(sorry, I forget this file quite frequently)

@ydshieh ydshieh merged commit 3714f3f into main Jun 4, 2024
8 checks passed
@ydshieh ydshieh deleted the upload_ci_results branch June 4, 2024 19:20
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 11, 2024
* build

* build

* build

* build

* fix

* fix

* fix

---------

Co-authored-by: ydshieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants