Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OWLv2 Doc #30794

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix OWLv2 Doc #30794

merged 1 commit into from
May 14, 2024

Conversation

jla524
Copy link
Contributor

@jla524 jla524 commented May 14, 2024

What does this PR do?

Fixes #30686 (comment)

Tested on a 7900 XTX machine

% pytest --doctest-modules docs/source/en/model_doc/owlv2.md -sv --doctest-continue-on-failure --doctest-glob="*.md"
<log redacted>
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.5.0 -- /home/jacky/repos/transformers/env/bin/python3
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase(PosixPath('/home/jacky/repos/transformers/.hypothesis/examples'))
rootdir: /home/jacky/repos/transformers
configfile: pyproject.toml
plugins: timeout-2.3.1, hydra-core-1.3.2, hypothesis-6.102.1, rich-0.1.1, xdist-3.6.1, dash-2.17.0, anyio-4.3.0
collected 1 item                                                                                                                           

docs/source/en/model_doc/owlv2.md::owlv2.md PASSED

<warnings redacted>
====================================================== 1 passed, 2 warnings in 4.26s =======================================================

Who can review?

@ydshieh @amyeroberts

@ydshieh ydshieh self-assigned this May 14, 2024
Detected a photo of a cat with confidence 0.614 at location [341.67, 17.54, 642.32, 278.51]
Detected a photo of a cat with confidence 0.665 at location [6.75, 38.97, 326.62, 354.85]
Detected a photo of a cat with confidence 0.614 at location [341.67, 23.39, 642.32, 371.35]
Detected a photo of a cat with confidence 0.665 at location [6.75, 51.96, 326.62, 473.13]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our T4 runners gives the same new value. Thank you for the quick fix @jla524 !

@ydshieh ydshieh merged commit 449894d into huggingface:main May 14, 2024
7 checks passed
@jla524 jla524 deleted the fix_owlv2_doc branch November 20, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants