-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow: Replace actions/post-slack
with centrally defined workflow
#30737
Conversation
Actually i might just remove that workflow completely in favor of: huggingface/hf-workflows#9 and use that centrally on all our HF repos |
OK, let me know what you decide and if you still want a review. My vote would be for a more central, unified workflow. FWIW, we shouldn't need to adapt ci runs here because of other libraries - it hints at unnecessary dependencies |
thanks, yes I agree, just waiting for @glegendre01 's review on that PR and I will modify this PR to use that centralized GHA instead 🙏 will ping you once all is set! |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
actions/post-slack
with centrally defined workflow
cc @amyeroberts this is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's always nice to see lots of code deleted :D
https://github.com/huggingface/transformers/actions/runs/9062296650/job/24895867294 seems to have broken the slow ci tests |
What does this PR do?
Cleans up a bit our actions repo by replacing the
actions/post-slack
workflow with the centrally defined one inhuggingface/hf-workflows
repositorycc @amyeroberts