-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Object detection pipeline] Lower threshold #30710
[Object detection pipeline] Lower threshold #30710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating!
Agreed, it's not BC but this seems like a better value
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
FYI, we usually use much more lower score threshold (e.g. 0.3) to see just tendency of the model. (+ Note that transformers has transformer architecture which have lower confidence level) https://github.com/IDEA-Research/DINO/blob/main/inference_and_visualization.ipynb |
@NielsRogge should we merge it, or do you have something to add? |
I haven't tried the pipeline yet with various thresholds. Do you think we should lower it even more? It could result in too many detections. Wondering what the best default value is |
@NielsRogge We can always lower it further if necessary. I'd merge as-is and based on observations / feedback we can always update. |
With my experiments on cppe-5 dataset With a quick search in other frameworks, I found for some models:
But in general, it depends on the model and dataset |
Ok thanks, will merge in that case. |
What does this PR do?
This PR proposes to lower the default threshold of the object detection pipeline. It is currently set to 0.9, which causes a lot of inference widgets to not show any detected objects.