Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safetensors to model not found error msg for default use_safetensors value #30602

Conversation

davidgxue
Copy link
Contributor

@davidgxue davidgxue commented May 1, 2024

What does this PR do?

Fixes #30601

  • See details in the issue linked
  • TL;DR: Most people load using .from_pretrained() without explicitly specifying use_safetensors arg. This use_safetensors arg will default to None if not specified AND if system has safetensors library installed. When a model is being loaded and no modeling file is found and use_safetensors is defauled to None, model.safetensors does not get mentioned as part of the error message that lists out all the model files formats it has attempted to load, leading to confusion that safetensors may not be supported or should not be used.
  • There are error messages specifically made for loading safetensors but they only cover the explicitly True case. The idea here is that the comprehensive error message should list all model types when use_safetensors is defaulted to None.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this and improving the error messages!

@amyeroberts amyeroberts merged commit cf7bed9 into huggingface:main May 7, 2024
19 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 10, 2024
…ors value (huggingface#30602)

* add safetensors to model not found error for default use_safetensors=None case

* format code w/ ruff

* fix assert true typo
itazap pushed a commit that referenced this pull request May 14, 2024
…ors value (#30602)

* add safetensors to model not found error for default use_safetensors=None case

* format code w/ ruff

* fix assert true typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model.safetensors missing in model file not found error in default case
2 participants