Make accelerate install non-torch dependent #30463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
reviewed
Apr 24, 2024
.circleci/create_circleci_config.py
Outdated
| @@ -285,7 +285,8 @@ def job_name(self): | |||
| "pip install --upgrade --upgrade-strategy eager pip", | |||
| "pip install -U --upgrade-strategy eager .[sklearn,tf-cpu,torch,testing,sentencepiece,torch-speech,vision]", | |||
| "pip install -U --upgrade-strategy eager tensorflow_probability", | |||
| "pip install -U --upgrade-strategy eager -e git+https://github.com/huggingface/accelerate@main#egg=accelerate", | |||
| # Without this we can't pin torch versions in the future | |||
There was a problem hiding this comment.
maybe replace this with --no-deps and explain what we can't pin torch versions in the future means or replace it with a more detailed sentence?
amyeroberts
approved these changes
Apr 24, 2024
amyeroberts
reviewed
Apr 24, 2024
|
I guess you somehow forgot to change to dependency versions (unless that is what you intended to) |
|
@ydshieh in the mix this just needs to be rebased, should be fine :) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
muellerzr
force-pushed
the
muellerzr-nodep-accelerate
branch
2 times, most recently
from
7597667
to
79f8e56
Compare
|
I mean |
Co-authored-by: amyeroberts <[email protected]>
muellerzr
force-pushed
the
muellerzr-nodep-accelerate
branch
from
79f8e56
to
7c098c6
Compare
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* Pin accelerate w/o eager * Eager * Update .circleci/create_circleci_config.py Co-authored-by: amyeroberts <[email protected]> * Expound * Expound squared * PyTorch -> dependency --------- Co-authored-by: amyeroberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
acceleratedeps from eager install, which will upgrade pytorch dep. Should be okay as I think all of the required deps are installed normally with transformers anyways.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@amyeroberts @ydshieh