-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Llama
family, fix use_cache=False
generation
#30380
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for fixing! 💛
Suggestion: add a fast llama + generate + no cache test
Yeah, but it feels like this should be part of the generation mixin tests (and AFAIR it is?) |
* nit to make sure cache positions are not sliced * fix other models * nit * style
* nit to make sure cache positions are not sliced * fix other models * nit * style
What does this PR do?
fixes #30347