Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] vestiges of causal mask #29806

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[cleanup] vestiges of causal mask #29806

merged 1 commit into from
Mar 22, 2024

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Mar 22, 2024

What does this PR do?

Clean causal mask vestiges.
Slow test are catching this!

@ArthurZucker ArthurZucker marked this pull request as ready for review March 22, 2024 10:51
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it fixes the slow tests!

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this and fixing!

@amyeroberts
Copy link
Collaborator

Merging so I can prepare the patch - thanks again!

@amyeroberts amyeroberts merged commit 2e7cb46 into main Mar 22, 2024
18 checks passed
@amyeroberts amyeroberts deleted the fix-nit-gemma branch March 22, 2024 12:25
amyeroberts pushed a commit that referenced this pull request Mar 22, 2024
itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants