[`CI update`] Try to use dockers and no cache #29202

ArthurZucker · 2024-02-22T06:13:56Z

What does this PR do?

So we have:

1. `setup_and_quality` 83% faster on average, instead of a total of 11min it's down to 2min36.

I think we can do even better with check repo consistency by reducing the size of the docker used! (purging nvidia-*, and else not needed for checks). Breakdown:

2x on check circle ci user (from 14sec -> 7s)
10x on check code quality (from 6min -> 30s)
2x on check repo consistency (from 1min -> 30s)
2x on test fetching (from 1min -> 30s)

2. `run_tests` from 17min on average to 6min

before vs after:

HuggingFaceDocBuilderDev · 2024-02-22T07:53:49Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

ArthurZucker · 2024-04-01T07:15:43Z

I mostly need the approval of the security team at this point...

…e-ci

ArthurZucker · 2024-05-03T07:21:53Z

docker/custom-tokenizers.dockerfile

tests/models/layoutlmv2/test_image_processing_layoutlmv2.py

ydshieh · 2024-05-03T08:10:52Z

Wow, all ✅ ! I ❤️ seeing this. Will take a look this afternoon.
(But you can already remove Draft from the title 😉 )

docker/quality.dockerfile

LysandreJik · 2024-05-03T10:05:52Z

setup.py

-# Might need to add doc-builder and some specific deps in the future
-extras["docs_specific"] = ["hf-doc-builder"]
-
-# "docs" needs "all" to resolve all the references
-extras["docs"] = extras["all"] + extras["docs_specific"]


.circleci/create_circleci_config.py

.github/workflows/build-ci-docker-images.yml

setup.py

src/transformers/models/tapas/modeling_tf_tapas.py

LysandreJik · 2024-05-03T10:17:14Z

(please wait for Yih-Dar's review before merging)

ydshieh

Thank you @ArthurZucker . This is really great work 🚀 .

Mostly some nit comments, and let discuss/think about the image push process after this being merged.

(Please don't merge yet before I DM you on slack)

docker/consistency.dockerfile

.circleci/create_circleci_config.py

docker/torch-light.dockerfile

.github/workflows/build-ci-docker-images.yml

.circleci/create_circleci_config.py

src/transformers/models/groupvit/modeling_tf_groupvit.py

src/transformers/models/tapas/modeling_tf_tapas.py

Co-authored-by: Lysandre Debut <[email protected]>

…change-ci

@v4

* change cis * nits * update * minor updates * [push-ci-image] * nit [push-ci-image] * nitsssss * [build-ci-image] * [push-ci-image] * [push-ci-image] * both * [push-ci-image] * this? * [push-ci-image] * pypi-kenlm needs g++ * [push-ci-image] * nit * more nits [push-ci-image] * nits [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * add vision * [push-ci-image] * [push-ci-image] * add new dummy file but will need to update them [push-ci-image] * [push-ci-image] * show package size as well * [push-ci-image] * potentially ignore failures * workflow updates * nits [push-ci-image] * [push-ci-image] * fix consistency * clean nciida triton * also show big packages [push-ci-image] * nit * update * another one * line escape? * add accelerate [push-ci-image] * updates [push-ci-image] * nits to run tests, no push-ci * try to parse skip reason to make sure nothing is skipped that should no be skippped * nit? * always show skipped reasons * nits * better parsing of the test outputs * action="store_true", * failure on failed * show matched * debug * update short summary with skipped, failed and errors * nits * nits * coolu pdates * remove docbuilder * fix * always run checks * oups * nits * don't error out on library printing * non zero exi codes * no warning * nit * WAT? * format nit * [push-ci-image] * fail if fail is needed * [push-ci-image] * sound file for torch light? * [push-ci-image] * order is important [push-ci-image] * [push-ci-image] reduce even further * [push-ci-image] * use pytest rich ! * yes [push-ci-image] * oupsy * bring back the full traceback, but pytest rich should help * nit * [push-ci-image] * re run * nit * [push-ci-image] * [push-ci-image] * [push-ci-image] * empty push to trigger * [push-ci-image] * nit? [push-ci-image] * empty * try to install timm with no deps * [push-ci-image] * oups [push-ci-image] * [push-ci-image] * [push-ci-image] ? * [push-ci-image] open ssh client for git checkout fast * empty for torch light * updates [push-ci-image] * nit * @v4 for checkout * [push-ci-image] * [push-ci-image] * fix fetch tests with parallelism * [push-ci-image] * more parallelism * nit * more nits * empty to re-trigger * empty to re-trigger * split by timing * did not work with previous commit * junit.xml * no path? * mmm this? * junitxml format * split by timing * nit * fix junit family * now we can test if the xunit1 is compatible! * this? * fully list tests * update * update * oups * finally * use classname * remove working directory to make sure the path does not interfere * okay no juni should have the correct path * name split? * sort by classname is what make most sense * some testing * naem * oups * test something fun * autodetect * 18? * nit * file size? * uip * 4 is best * update to see versions * better print * [push-ci-image] * [push-ci-image] * please install the correct keras version * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * uv is fucking me up * [push-ci-image] * [push-ci-image] * [push-ci-image] * nits * [push-ci-image] * [push-ci-image] * install issues an pins * tapas as well * nits * more paralellism * short tb * soundfile * soundfile * [push-ci-image] * [push-ci-image] * [push-ci-image] * oups * [push-ci-image] * fix some things * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * use torch-light for hub * small git lfs for hub job * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * fix tf tapas * [push-ci-image] * nits * [push-ci-image] * don't update the test * [push-ci-image] * [push-ci-image] * [push-ci-image] * no use them * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * update tf proba * [push-ci-image] * [push-ci-image] * woops * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * test with built dockers * [push-ci-image] * skip annoying tests * revert fix copy * update test values * update * last skip and fixup * nit * ALL GOOOD * quality * Update tests/models/layoutlmv2/test_image_processing_layoutlmv2.py * Update docker/quality.dockerfile Co-authored-by: Lysandre Debut <[email protected]> * Update src/transformers/models/tapas/modeling_tf_tapas.py Co-authored-by: Lysandre Debut <[email protected]> * Apply suggestions from code review Co-authored-by: Lysandre Debut <[email protected]> * use torch-speed * updates * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * fuck ken-lm [push-ci-image] * [push-ci-image] * [push-ci-image] --------- Co-authored-by: Lysandre Debut <[email protected]>

@v4

* change cis * nits * update * minor updates * [push-ci-image] * nit [push-ci-image] * nitsssss * [build-ci-image] * [push-ci-image] * [push-ci-image] * both * [push-ci-image] * this? * [push-ci-image] * pypi-kenlm needs g++ * [push-ci-image] * nit * more nits [push-ci-image] * nits [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * add vision * [push-ci-image] * [push-ci-image] * add new dummy file but will need to update them [push-ci-image] * [push-ci-image] * show package size as well * [push-ci-image] * potentially ignore failures * workflow updates * nits [push-ci-image] * [push-ci-image] * fix consistency * clean nciida triton * also show big packages [push-ci-image] * nit * update * another one * line escape? * add accelerate [push-ci-image] * updates [push-ci-image] * nits to run tests, no push-ci * try to parse skip reason to make sure nothing is skipped that should no be skippped * nit? * always show skipped reasons * nits * better parsing of the test outputs * action="store_true", * failure on failed * show matched * debug * update short summary with skipped, failed and errors * nits * nits * coolu pdates * remove docbuilder * fix * always run checks * oups * nits * don't error out on library printing * non zero exi codes * no warning * nit * WAT? * format nit * [push-ci-image] * fail if fail is needed * [push-ci-image] * sound file for torch light? * [push-ci-image] * order is important [push-ci-image] * [push-ci-image] reduce even further * [push-ci-image] * use pytest rich ! * yes [push-ci-image] * oupsy * bring back the full traceback, but pytest rich should help * nit * [push-ci-image] * re run * nit * [push-ci-image] * [push-ci-image] * [push-ci-image] * empty push to trigger * [push-ci-image] * nit? [push-ci-image] * empty * try to install timm with no deps * [push-ci-image] * oups [push-ci-image] * [push-ci-image] * [push-ci-image] ? * [push-ci-image] open ssh client for git checkout fast * empty for torch light * updates [push-ci-image] * nit * @v4 for checkout * [push-ci-image] * [push-ci-image] * fix fetch tests with parallelism * [push-ci-image] * more parallelism * nit * more nits * empty to re-trigger * empty to re-trigger * split by timing * did not work with previous commit * junit.xml * no path? * mmm this? * junitxml format * split by timing * nit * fix junit family * now we can test if the xunit1 is compatible! * this? * fully list tests * update * update * oups * finally * use classname * remove working directory to make sure the path does not interfere * okay no juni should have the correct path * name split? * sort by classname is what make most sense * some testing * naem * oups * test something fun * autodetect * 18? * nit * file size? * uip * 4 is best * update to see versions * better print * [push-ci-image] * [push-ci-image] * please install the correct keras version * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * uv is fucking me up * [push-ci-image] * [push-ci-image] * [push-ci-image] * nits * [push-ci-image] * [push-ci-image] * install issues an pins * tapas as well * nits * more paralellism * short tb * soundfile * soundfile * [push-ci-image] * [push-ci-image] * [push-ci-image] * oups * [push-ci-image] * fix some things * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * use torch-light for hub * small git lfs for hub job * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * fix tf tapas * [push-ci-image] * nits * [push-ci-image] * don't update the test * [push-ci-image] * [push-ci-image] * [push-ci-image] * no use them * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * update tf proba * [push-ci-image] * [push-ci-image] * woops * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * test with built dockers * [push-ci-image] * skip annoying tests * revert fix copy * update test values * update * last skip and fixup * nit * ALL GOOOD * quality * Update tests/models/layoutlmv2/test_image_processing_layoutlmv2.py * Update docker/quality.dockerfile Co-authored-by: Lysandre Debut <[email protected]> * Update src/transformers/models/tapas/modeling_tf_tapas.py Co-authored-by: Lysandre Debut <[email protected]> * Apply suggestions from code review Co-authored-by: Lysandre Debut <[email protected]> * use torch-speed * updates * [push-ci-image] * [push-ci-image] * [push-ci-image] * [push-ci-image] * fuck ken-lm [push-ci-image] * [push-ci-image] * [push-ci-image] --------- Co-authored-by: Lysandre Debut <[email protected]>

ArthurZucker mentioned this pull request Mar 5, 2024

Use uv in CI to speed-up requirements install huggingface/huggingface_hub#2072

Merged

huggingface deleted a comment from github-actions bot Apr 1, 2024

change cis

330f3b8

ArthurZucker force-pushed the change-ci branch from 37755b7 to 330f3b8 Compare April 26, 2024 12:55

ArthurZucker added 24 commits April 26, 2024 14:58

Merge branch 'main' of github.com:huggingface/transformers into chang…

7638069

…e-ci

nits

8d83417

update

b2d4677

minor updates

0c5cd63

[push-ci-image]

fcb03b5

nit [push-ci-image]

f2497de

nitsssss

d7d09ae

[build-ci-image]

3a1a922

[push-ci-image]

53c341c

[push-ci-image]

1e3f97f

both

650e6a6

[push-ci-image]

c3c0221

this?

bf29d95

[push-ci-image]

dc9de14

pypi-kenlm needs g++

4048bf8

[push-ci-image]

2cb78cf

nit

85c9d0d

more nits [push-ci-image]

226e952

nits [push-ci-image]

08fb481

[push-ci-image]

bd16314

[push-ci-image]

e0238df

[push-ci-image]

32ff594

add vision

60b0e7c

[push-ci-image]

8b93057

ArthurZucker added 5 commits May 3, 2024 08:30

Merge branch 'main' of github.com:huggingface/transformers into chang…

eb8b69b

…e-ci

last skip and fixup

e71b18f

nit

f479bfd

ALL GOOOD

a020478

quality

896f0c0

ArthurZucker commented May 3, 2024

View reviewed changes

docker/custom-tokenizers.dockerfile Show resolved Hide resolved

tests/models/layoutlmv2/test_image_processing_layoutlmv2.py Outdated Show resolved Hide resolved

ArthurZucker changed the title ~~[Draft CI update] Try to use dockers and no cache~~ [CI update] Try to use dockers and no cache May 3, 2024

LysandreJik approved these changes May 3, 2024

View reviewed changes

ydshieh approved these changes May 3, 2024

View reviewed changes

ArthurZucker and others added 14 commits May 6, 2024 08:42

Update tests/models/layoutlmv2/test_image_processing_layoutlmv2.py

27929ba

Update docker/quality.dockerfile

89e3353

Co-authored-by: Lysandre Debut <[email protected]>

Update src/transformers/models/tapas/modeling_tf_tapas.py

8b094f8

Co-authored-by: Lysandre Debut <[email protected]>

Apply suggestions from code review

1d6ceec

Co-authored-by: Lysandre Debut <[email protected]>

use torch-speed

b6fc187

updates

e4f4e23

[push-ci-image]

15dde2c

Merge branch 'change-ci' of github.com:huggingface/transformers into …

de0b945

…change-ci

[push-ci-image]

4e4a2e0

[push-ci-image]

b8ab028

[push-ci-image]

514caeb

fuck ken-lm [push-ci-image]

b663f61

[push-ci-image]

23b48ac

[push-ci-image]

d47d214

ArthurZucker merged commit 307f632 into main May 6, 2024
30 of 34 checks passed

ArthurZucker deleted the change-ci branch May 6, 2024 08:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[`CI update`] Try to use dockers and no cache #29202

[`CI update`] Try to use dockers and no cache #29202

ArthurZucker commented Feb 22, 2024 •

edited

Loading

HuggingFaceDocBuilderDev commented Feb 22, 2024

ArthurZucker commented Apr 1, 2024

ArthurZucker commented May 3, 2024

ydshieh commented May 3, 2024

LysandreJik May 3, 2024

LysandreJik commented May 3, 2024

ydshieh left a comment

[CI update] Try to use dockers and no cache #29202

[CI update] Try to use dockers and no cache #29202

Conversation

ArthurZucker commented Feb 22, 2024 • edited Loading

What does this PR do?

1. setup_and_quality 83% faster on average, instead of a total of 11min it's down to 2min36.

2. run_tests from 17min on average to 6min

HuggingFaceDocBuilderDev commented Feb 22, 2024

ArthurZucker commented Apr 1, 2024

ArthurZucker commented May 3, 2024

ydshieh commented May 3, 2024

LysandreJik May 3, 2024

Choose a reason for hiding this comment

LysandreJik commented May 3, 2024

ydshieh left a comment

Choose a reason for hiding this comment

[`CI update`] Try to use dockers and no cache #29202

[`CI update`] Try to use dockers and no cache #29202

ArthurZucker commented Feb 22, 2024 •

edited

Loading

1. `setup_and_quality` 83% faster on average, instead of a total of 11min it's down to 2min36.

2. `run_tests` from 17min on average to 6min