Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: feat: add llama2 notebook resources from OSSCA community #26076

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

junejae
Copy link
Contributor

@junejae junejae commented Sep 10, 2023

What does this PR do?

Adds a notebook resource of LLaMA2 on how to fine-tune LLaMA2 as a Korean text classifier.
The notebook is created by our OSSCA community.
Part of #20055

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

May you please review this PR?
@bolizabeth, @nuatmochoi, @heuristicwave, @mjk0618, @keonju2, @harheem, @HongB1, @junejae, @54data, @seank021, @augustinLib, @sronger, @TaeYupNoh, @kj021, @eenzeenee

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for creating a notebook! 🤗

I wasn't able to get the code in it to run successfully though. I get the following error because I think in your implementation of the TrainingArgument class you have batch_size instead of per_device_train_batch_size?

TypeError: TrainingArguments.__init__() got an unexpected keyword argument 'per_device_train_batch_size'

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@junejae
Copy link
Contributor Author

junejae commented Sep 12, 2023

Nice, thanks for creating a notebook! 🤗

I wasn't able to get the code in it to run successfully though. I get the following error because I think in your implementation of the TrainingArgument class you have batch_size instead of per_device_train_batch_size?

TypeError: TrainingArguments.__init__() got an unexpected keyword argument 'per_device_train_batch_size'

@stevhliu
It's fixed! Could you try it again?

I messed up my code while polishing some variable names.
I rolled back the change and tested. It works fine now!

@stevhliu
Copy link
Member

Cool, it works now; feel free to mark this as ready, and then we can merge!

@junejae junejae marked this pull request as ready for review September 13, 2023 06:44
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

@stevhliu stevhliu merged commit a6ae2bd into huggingface:main Sep 13, 2023
3 checks passed
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants