Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vision] fix small nit on BeitDropPath layers #20587

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Dec 5, 2022

What does this PR do?

Fixes a small nit for DropPath layers pointed out in: #20550 (comment) & #20550 (comment)

Preferred to fix this separately in a PR to avoid modifying too much files in #20550

cc @NielsRogge @patrickvonplaten

@younesbelkada younesbelkada changed the title [Vision] fix small nit [Vision] fix small nit on BeitDropPath layers Dec 5, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 5, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, better indeed!

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

BTW, I always hate this x kind variables, but this happens a lot in many many deep learning repos, especially the vision models!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@younesbelkada younesbelkada merged commit 0911057 into huggingface:main Dec 5, 2022
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Dec 7, 2022
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
venkat-natchi pushed a commit to venkat-natchi/transformers that referenced this pull request Jan 22, 2023
miyu386 pushed a commit to miyu386/transformers that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants