Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add resources of OpenAI GPT #20084

Merged
merged 8 commits into from
Nov 16, 2022
Merged

[Docs] Add resources of OpenAI GPT #20084

merged 8 commits into from
Nov 16, 2022

Conversation

shogohida
Copy link
Contributor

@shogohida shogohida commented Nov 6, 2022 •
edited
Loading

What does this PR do?

Adds resources of OpenAI GPT according to this issue

Fixes #20055 (partially)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@shogohida shogohida mentioned this pull request Nov 6, 2022
Closed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sgugger sgugger requested a review from stevhliu November 7, 2022 14:55
stevhliu
stevhliu reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start @shogohida! 👍

If you can also add the relevant scripts and notebooks for the tasks your model is capable of, that'd be awesome!

docs/source/en/model_doc/openai-gpt.mdx Outdated Show resolved Hide resolved
docs/source/en/model_doc/openai-gpt.mdx Outdated Show resolved Hide resolved
@stevhliu stevhliu mentioned this pull request Nov 7, 2022
Closed
20 tasks
@shogohida shogohida marked this pull request as ready for review November 13, 2022 19:50
@shogohida
Copy link
Contributor Author

Hi @stevhliu, I added relevant scripts and notebooks so please have a look!

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

stevhliu
stevhliu reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for adding those. Now you just have a few more to go! 😁

Take a look at the OpenAI GPT2 resources page and feel free to add over whatever is missing here since the usage for OpenAI GPT is practically the same.

docs/source/en/model_doc/openai-gpt.mdx Outdated Show resolved Hide resolved
docs/source/en/model_doc/openai-gpt.mdx Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@shogohida
Copy link
Contributor Author

@stevhliu
I changed the doc following your comments! Please have a look

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

stevhliu
stevhliu reviewed Nov 15, 2022
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for iterating and improving this, just one last change and I think we're good to go!

docs/source/en/model_doc/openai-gpt.mdx Outdated Show resolved Hide resolved
stevhliu
stevhliu approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution! Pinging @sgugger for a final look :)

sgugger
sgugger approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit 3897022 into huggingface:main Nov 16, 2022
@shogohida shogohida deleted the add-resources-of-openai-gpt branch November 16, 2022 21:00
@shogohida
Copy link
Contributor Author

@stevhliu @sgugger
Thanks for your review! Hope to contribute more to transformers!

mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
@shogohida @stevhliu
[Docs] Add resources of OpenAI GPT (huggingface#20084)
a28961b 
* Add resources of OpenAI GPT

* Delete Deploy section and add .

* Add scripts

* Update docs/source/en/model_doc/openai-gpt.mdx

Co-authored-by: Steven Liu <[email protected]>

* Delete causal-language-modeling section

* Add TFOpenAIGPTLMHeadModel

* Add resources from community

* Delete a link

Co-authored-by: Steven Liu <[email protected]>
@wonhyeongseo wonhyeongseo mentioned this pull request Aug 16, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model resources contribution
4 participants
@shogohida @HuggingFaceDocBuilderDev @sgugger @stevhliu