Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for prepare_tf_dataset when drop_remainder is not supplied #17950

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fix for prepare_tf_dataset when drop_remainder is not supplied #17950

merged 1 commit into from
Jun 29, 2022

Conversation

Rocketknight1
Copy link
Member

Super-minor fix for an oversight that causes a crash when drop_remainder is left at the default None!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 29, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

gante
gante approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (perhaps with a warning?)

@Rocketknight1
Copy link
Member Author

It's the same behaviour as Keras and to_tf_dataset(), so I think people will expect it!

@Rocketknight1 Rocketknight1 merged commit 5feac3d into main Jun 29, 2022
@Rocketknight1 Rocketknight1 deleted the prepare_tf_model_bugfix branch June 29, 2022 18:23
viclzhu pushed a commit to viclzhu/transformers that referenced this pull request Jul 18, 2022
@Rocketknight1 @viclzhu
Fix prepare_tf_dataset when drop_remainder is not supplied (huggingfa…
7037b9a 
…ce#17950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gante gante gante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rocketknight1 @HuggingFaceDocBuilderDev @gante