-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mrbean/codegen onnx #17903
Mrbean/codegen onnx #17903
Conversation
The documentation is not available anymore as the PR was closed or merged. |
("camembert", "camembert-base"), | ||
("convbert", "YituTech/conv-bert-base"), | ||
("codegen", "Salesforce/codegen-350M-multi"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small detail but this line should be in between camembert
and convbert
similar to how it is in the src/transformers/onnx/features.py
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this line should go to PYTORCH_EXPORT_WITH_PAST_MODELS
with gpt2
and gpt-neo
. Since it's a OnnxConfigWithPast
config
@sam-h-bean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing @NouamaneTazi, to make the test more organised, it would be better to place it in with_past model list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for adding the feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @lewtun you can merge if you're happy with the changes.
Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the fix and checking the slow tests pass @sam-h-bean 🚀 !!
This LGTM, so will go ahead with the merge
What does this PR do?
Codegen was added with an ONNX config but not with the model added to the features manager so trying to actually export an ONNX config is failing.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@patil-suraj @JingyaHuang