Fix test_number_of_steps_in_training_with_ipex
#17889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
requested review from
sgugger and
stas00
and removed request for
sgugger
sgugger
approved these changes
Jun 27, 2022
younesbelkada
pushed a commit
to younesbelkada/transformers
that referenced
this pull request
Jun 29, 2022
Co-authored-by: ydshieh <[email protected]>
viclzhu
pushed a commit
to viclzhu/transformers
that referenced
this pull request
Jul 18, 2022
Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
test_number_of_steps_in_training_with_ipex.Details
This test uses
no_cuda=True, which will changen_gputo0(see_setup_devices), andtrain_batch_sizewill be8(with the default training args). However this linetransformers/tests/trainer/test_trainer.py
Line 590 in 93f48da
is computed (earlier) with GPUs, and therefore the (total) batch size is
16when 2 GPUs is available.This cause the following error.
Currently test error
tests/trainer/test_trainer.py::TrainerIntegrationTest::test_number_of_steps_in_training_with_ipex (line 652) AssertionError: 24 != 12.0