Add type hints for gptneox models #17858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Rocketknight1
approved these changes
Jun 24, 2022
donelianc
reviewed
Jun 24, 2022
| output_hidden_states=None, | ||
| return_dict=None, | ||
| ): | ||
| input_ids: Optional[torch.LongTensor] = None, |
There was a problem hiding this comment.
According to the documentation of GPT-NeoX, the parameter input_ids is not optional for the class GPTNeoXModel.
There was a problem hiding this comment.
While this is true, Optional in Python types has the very specific meaning that the argument can take the value None. See the typing docs for more info on this.
I agree it's not exactly intuitive, but the annotation here is correct as the argument has a default value of None!
There was a problem hiding this comment.
Great! Thanks for sharing this information. I'm using this PR as an example to continue addressing the issue 16059. Again, thanks 😃
younesbelkada
pushed a commit
to younesbelkada/transformers
that referenced
this pull request
Jun 25, 2022
* feat: Add type hints for GPTNeoxForCausalLM and GPTNeoXModel * fix: removed imported Dict type * fix: Removed unused List import
younesbelkada
pushed a commit
to younesbelkada/transformers
that referenced
this pull request
Jun 29, 2022
* feat: Add type hints for GPTNeoxForCausalLM and GPTNeoXModel * fix: removed imported Dict type * fix: Removed unused List import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding missing type hints for
GPTNeoxForCausalLMandGPTNeoXModelas referenced in this issue.(#16059 (comment)).Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community please feel free to review😄
@Rocketknight1