Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Current
FlaxBigBirdEmbeddings
applies layer norm before dropout, whileBigBirdEmbeddings
and Google's originalBigBird
applies dropout first. This PR fixes this inconsistency.
Flax
(layernorm --> dropout)
transformers/src/transformers/models/big_bird/modeling_flax_big_bird.py
Lines 232 to 233 in 6f29029
PyTorch
(dropout immediately after embedding)
transformers/src/transformers/models/big_bird/modeling_big_bird.py
Lines 311 to 312 in 6f29029
Google
(dropout immediately after embedding)
https://github.com/google-research/bigbird/blob/5f2a5aa7fbab23e32e0e0b41c5f0192f0c023e05/bigbird/core/utils.py#L565-L566