Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Python-base tokenizer by non-fast tokenizer in error message #17836

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

SaulLu
Copy link
Contributor

@SaulLu SaulLu commented Jun 23, 2022

What does this PR do?

As one user rightly pointed out in an issue #17809, when a user receives the error "tokens() is not available when using Python-based tokenizers" it is not obvious that a python-based tokenizer refers to a tokenizer class without the term Fast at the end.

I therefore propose to change the error messages using this term to refer to the term fast which is more easily understood by users.

Fixes #17809

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Would love to have the approval of @sgugger , @LysandreJik , @patrickvonplaten or @patil-suraj 🤗

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 23, 2022

The documentation is not available anymore as the PR was closed or merged.

@SaulLu SaulLu merged commit b2fdbac into huggingface:main Jun 23, 2022
younesbelkada pushed a commit to younesbelkada/transformers that referenced this pull request Jun 25, 2022
younesbelkada pushed a commit to younesbelkada/transformers that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoTokenizer vs. BertTokenizer
3 participants