Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifact path for cuda extension test in push CI #17788

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 21, 2022

What does this PR do?

Fix artifact path for cuda extension test in push CI

More details

In #17335, working-director is updated (a fix) for (single-gpu) cuda extension test, but the artifact path was not updated, which leads to strange slack report.

      - name: Run all non-slow selected tests on GPU
        working-directory: /workspace/transformers
        ...

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@ydshieh ydshieh merged commit 8d634b7 into main Jun 23, 2022
@ydshieh ydshieh deleted the fix_push_ci_cuda_ext_test_artifact_path branch June 23, 2022 10:31
younesbelkada pushed a commit to younesbelkada/transformers that referenced this pull request Jun 25, 2022
younesbelkada pushed a commit to younesbelkada/transformers that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants