Nezha Pytorch implementation #17776
Merged
Nezha Pytorch implementation #17776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into vqa_pipeline
Co-authored-by: NielsRogge <[email protected]>
…into vqa_pipeline
Co-authored-by: NielsRogge <[email protected]>
|
The documentation is not available anymore as the PR was closed or merged. |
sijunhe
changed the title
|
ready for review! I'll upload the rest of the pre-trained models later today |
sgugger
reviewed
Jun 21, 2022
There was a problem hiding this comment.
Very nice addition! This PR is in great shape, I just have two comments.
- Remove the capital Z in all
NeZhaXxxclasses (soNezhaConfig,NezhaModeletc). - Make sure the classes that are perfect duplicates of BERT classes have a
# Copied fromstatement like this one for RoBERTa.
Also, if the model's default tokenizer is BertTokenizer, consider adding a mapping from the model config to the BERT tokenizers in tokenization_auto.py.
Comment on lines
63
to
64
| # [to be uploaded] "sijunhe/nezha-large-wwm", | ||
| # [to be uploaded] "sijunhe/nezha-cn-large", |
There was a problem hiding this comment.
Flagging those so we don't forget to wait for them to be uploaded before merging :-)
|
addressed all the comments from @sgugger and uploaded the two remaining models. Ready for a final round of review. |
patrickvonplaten
approved these changes
Jun 23, 2022
|
Thanks again for your contribution! |
younesbelkada
pushed a commit
to younesbelkada/transformers
that referenced
this pull request
Jun 25, 2022
* wip * rebase * all tests pass * rebase * ready for PR * address comments * fix styles * add require_torch to pipeline test * remove remote image to improve CI consistency * address comments; fix tf/flax tests * address comments; fix tf/flax tests * fix tests; add alias * repo consistency tests * Update src/transformers/pipelines/visual_question_answering.py Co-authored-by: NielsRogge <[email protected]> * address comments * Update src/transformers/pipelines/visual_question_answering.py Co-authored-by: NielsRogge <[email protected]> * merge * wip * wip * wip * most basic tests passes * all tests pass now * relative embedding * wip * running make fixup * remove bert changes * fix doc * fix doc * fix issues * fix doc * address comments * fix CI * remove redundant copied from * address comments * fix broken test Co-authored-by: Sijun He <[email protected]> Co-authored-by: NielsRogge <[email protected]>
younesbelkada
pushed a commit
to younesbelkada/transformers
that referenced
this pull request
Jun 29, 2022
* wip * rebase * all tests pass * rebase * ready for PR * address comments * fix styles * add require_torch to pipeline test * remove remote image to improve CI consistency * address comments; fix tf/flax tests * address comments; fix tf/flax tests * fix tests; add alias * repo consistency tests * Update src/transformers/pipelines/visual_question_answering.py Co-authored-by: NielsRogge <[email protected]> * address comments * Update src/transformers/pipelines/visual_question_answering.py Co-authored-by: NielsRogge <[email protected]> * merge * wip * wip * wip * most basic tests passes * all tests pass now * relative embedding * wip * running make fixup * remove bert changes * fix doc * fix doc * fix issues * fix doc * address comments * fix CI * remove redundant copied from * address comments * fix broken test Co-authored-by: Sijun He <[email protected]> Co-authored-by: NielsRogge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a pytorch implementation of the NEZHA model to transformers. NEZHA was introduced by Huawei Noah's Ark Lab in late 2019 and it is widely used in the Chinese NLP community. This implementation is based on the official pytorch implementation of NEZHA and the current BERT pytorch implementation . The model checkpoints are also from the official implementation.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Since the model is quite similar to bert, maybe @LysandreJik?