Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add flag to push TF weights directly into main #17720

Merged
merged 3 commits into from
Jun 15, 2022

Conversation

gante
Copy link
Member

@gante gante commented Jun 15, 2022

What does this PR do?

Adds the --push flag to the pt-to-tf CLI, to enabling pushing straight to main (assuming the user has the right permissions).

Why am I adding this flag? A few users mentioned that they would be interested in having TF weights silently pushed straight into their repos. With this flag, I can start building a local midnight cronjob to automate the conversions (starting with pushes for users that requested it, then PR opening on users interested in PRs, then 1 PR per user if not whitelisted), which can eventually be moved into a separate machine to continuously feed the TF ecosystem 🔥

@Rocketknight1
Copy link
Member

Yes yes yes! Maybe users could just set a flag, like "auto-convert my weights" and then we could have a machine that tracks their repos, looks for weights files that have changed and auto-updates versions for the other frameworks?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 15, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

src/transformers/commands/pt_to_tf.py Outdated Show resolved Hide resolved
@gante gante merged commit c3c62b5 into huggingface:main Jun 15, 2022
@gante gante deleted the cli_push branch June 15, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants