Fix dtype getter #17668
Merged
Fix dtype getter #17668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
stas00
approved these changes
Jun 10, 2022
|
Errors seem all related to the current Hub failure, still, will wait for the site to be back online to relaunch them since this is not urgent :-) |
LysandreJik
approved these changes
Jun 13, 2022
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jun 16, 2022
* Fix dtype getters * Proper fix for dtype getter * Style and commant * Always use last for consistency * Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a better fix for #17656 as I've had time to dive deeper into this issue. The problem does appear when the model is wrapped in a
DataParallelobject, and not just for PyTorch 1.5.