Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Generation Test] Make fast test actually fast #17661

Merged

Conversation

patrickvonplaten
Copy link
Contributor

What does this PR do?

Speeds up tests/generation/test_generation_utils.py::GenerationIntegrationTests::test_constrained_beam_search_mixin_type_checks

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 10, 2022

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten patrickvonplaten merged commit 13e875c into huggingface:main Jun 10, 2022
@sgugger
Copy link
Collaborator

sgugger commented Jun 10, 2022

Thansk for fixing!

elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@patrickvonplaten patrickvonplaten deleted the generation-fix-slow-test branch June 12, 2022 22:18
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants