Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BigBirdFlaxTests] Make tests slow #17658

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Jun 10, 2022

What does this PR do?

Reduce testing time for BigBird Flax (saves ~4 minutes)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten
Copy link
Contributor Author

This reduces overall fast testing time of BigBird to 30 seconds from 4 minutes. It's still quite a bit, but if I remove more tests (or make them slow, we don't test the Flax version anymore at all really).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 10, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickvonplaten patrickvonplaten merged commit 5e428b7 into huggingface:main Jun 10, 2022
@patrickvonplaten patrickvonplaten deleted the flax_big_bird_make_tests_slow branch June 10, 2022 14:54
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* [BigBirdFlaxTests] Make tests slow

* up

* correct black with new version
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jun 16, 2022
* [BigBirdFlaxTests] Make tests slow

* up

* correct black with new version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants