TF: Merge PT and TF behavior for Bart when no decoder_input_ids are passed #17593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Jun 7, 2022
| if decoder_input_ids is None and decoder_inputs_embeds is None: | ||
| use_cache = False | ||
|
|
||
| output_hidden_states = ( |
There was a problem hiding this comment.
TFBartMainLayer (i.e. this class) is not a stand-alone class, output_hidden_states is always passed from the stand-alone classes. This line was redundant and thus removed.
|
The documentation is not available anymore as the PR was closed or merged. |
Rocketknight1
approved these changes
Jun 8, 2022
patrickvonplaten
approved these changes
Jun 8, 2022
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…assed (huggingface#17593) * Merge PT and TF behavior
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jun 16, 2022
…assed (huggingface#17593) * Merge PT and TF behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The main model for TF and PT have a different behavior when no
decoder_input_idsare passed. Because of that, the same model with the same inputs has different outputs in the two platforms, in this specific input case.Looking at the git blame, it seems like this
ifbranch in PT has added after the TF model was added, and we possibly forgot to port it back.Notes:
pt-to-tfCLI, which added much stricter tests.