Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fx support for Deberta-v[1-2], Hubert and LXMERT #17539

Merged

Conversation

michaelbenayoun
Copy link
Member

What does this PR do?

Adds torch.fx tracing support for:

  • Deberta v1
  • Deberta v2
  • Hubert
  • LXMERT

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 3, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for those new models!

Comment on lines +787 to +792
if (
isinstance(model, tuple(MODEL_FOR_SEQUENCE_CLASSIFICATION_MAPPING.values()))
and not hasattr(model.config, "problem_type")
or model.config.problem_type is None
):
model.config.problem_type = "single_label_classification"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I get the change of config here. Why use a checkpoint with a non-supported problem_type for the test?

@michaelbenayoun michaelbenayoun merged commit 5c8f601 into huggingface:main Jun 7, 2022
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* Support for deberta and deberta-v2

* Support for LXMert

* Support for Hubert

* Fix for pt1.11

* Trigger CI
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jun 16, 2022
* Support for deberta and deberta-v2

* Support for LXMert

* Support for Hubert

* Fix for pt1.11

* Trigger CI
@michaelbenayoun michaelbenayoun deleted the fx_deberta_hubert_lxmert branch June 20, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants