Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change unpacking of TF Bart inputs to use decorator #16094

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Change unpacking of TF Bart inputs to use decorator #16094

merged 1 commit into from
Mar 12, 2022

Conversation

osanseviero
Copy link
Contributor

@osanseviero osanseviero commented Mar 11, 2022 •
edited
Loading

What does this PR do?

As part of #16051 this PR changes the unpacking of the inputs of bart to use the decorator instead.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1

Am I a TF engineer now? 😅

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 11, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@Rocketknight1
Copy link
Member

Just straight-up assigning @gante to review the decorator PRs 👼

gante
gante approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats @osanseviero, you are now one of us 😱

@gante gante merged commit 3e9d0f7 into master Mar 12, 2022
@gante gante deleted the bart-tf-naming branch March 12, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gante gante gante approved these changes

@Rocketknight1 Rocketknight1 Awaiting requested review from Rocketknight1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osanseviero @HuggingFaceDocBuilderDev @Rocketknight1 @gante