Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][examples/seq2seq] move old s2s scripts to legacy #10136

Merged
merged 9 commits into from
Feb 15, 2021
Merged

[WIP][examples/seq2seq] move old s2s scripts to legacy #10136

merged 9 commits into from
Feb 15, 2021

Conversation

patil-suraj
Copy link
Contributor

@patil-suraj patil-suraj commented Feb 11, 2021 •
edited
Loading

What does this PR do?

Move the finetune_trainer.py and related utils, tests, bash scripts to examples/legacy/seq2seq

@patil-suraj patil-suraj changed the title [examples/seq2seq] move old s2s scripts to legacy [WIP][examples/seq2seq] move old s2s scripts to legacy Feb 11, 2021
@patil-suraj patil-suraj marked this pull request as draft February 11, 2021 09:19
@patil-suraj patil-suraj mentioned this pull request Feb 12, 2021
Merged
@patil-suraj patil-suraj marked this pull request as ready for review February 12, 2021 11:55
@stas00 stas00 self-requested a review February 12, 2021 17:30
stas00
stas00 approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know there was an urgency with this but if it's important go for it and I will re-port things back from the dead, so your project can proceed.

sgugger
sgugger approved these changes Feb 15, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this Suraj! Once the PR that ports the tests to the new script is merged, we can merge this one.

examples/legacy/seq2seq/README.md Outdated Show resolved Hide resolved
examples/legacy/seq2seq/README.md Outdated Show resolved Hide resolved
@stas00 stas00 merged commit 1c8c2d9 into huggingface:master Feb 15, 2021
@patil-suraj
Copy link
Contributor Author

Thanks a lot Stas and Sylvain :)

@patil-suraj patil-suraj deleted the cleanup-s2s-dir branch February 15, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@stas00 stas00 stas00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patil-suraj @stas00 @sgugger