Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model file name #594

Merged
merged 12 commits into from
May 23, 2024
Merged

Add model file name #594

merged 12 commits into from
May 23, 2024

Conversation

NawarA
Copy link
Contributor

@NawarA NawarA commented Feb 20, 2024

No description provided.

@NawarA
Copy link
Contributor Author

NawarA commented Feb 20, 2024

@xenova here's the promised PR for #509

I'll try to expand the solution to encoder-decoder models once I begin working with them.

@NawarA
Copy link
Contributor Author

NawarA commented Feb 20, 2024

In the PR, you'll see my system trimmed white spaces, and the only change is:

image

@xenova
Copy link
Collaborator

xenova commented Feb 24, 2024

Thanks for the PR! Just to keep the diff small, can you remove any whitespace formatting applied by your editor? There definitely are valid changes, but it will make the diff large for the PR. 🤗

@NawarA
Copy link
Contributor Author

NawarA commented Mar 7, 2024

Thanks for the PR! Just to keep the diff small, can you remove any whitespace formatting applied by your editor? There definitely are valid changes, but it will make the diff large for the PR. 🤗

@xenova Absolutely. Done.

Thanks for the suggestion. The PR now has two lines changed. Much cleaner!

The PR is also merged with 2.16.0 (released a few hours ago), and is ready to go :)

@NawarA
Copy link
Contributor Author

NawarA commented Mar 24, 2024

The PR is merged with 2.16.1 and is ready to go :)

@Th3G33k
Copy link

Th3G33k commented May 9, 2024

@xenova Those changes are already in v3. This PR should be merge into main, or close until v3 arrives

Copy link
Collaborator

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nits applied to keep future diffs small

src/pipelines.js Outdated Show resolved Hide resolved
src/pipelines.js Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@xenova
Copy link
Collaborator

xenova commented May 23, 2024

I'll try to expand the solution to encoder-decoder models once I begin working with them.

I'll make the necessary changes in v3 myself. For now, this is okay (and will work for all single-file models, like encoder-only and decoder-only models).

@xenova xenova merged commit 250fcd7 into huggingface:main May 23, 2024
1 of 4 checks passed
@NawarA NawarA deleted the add-model-file-name branch June 1, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants