Clippy fixes. #846
Merged
Clippy fixes. #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McPatate
approved these changes
Dec 15, 2021
| @@ -11,7 +11,7 @@ pub enum EncodeTask<'s> { | |||
| } | |||
|
|
|||
| pub enum EncodeOutput { | |||
| Single(Encoding), | |||
| Single(Box<Encoding>), | |||
There was a problem hiding this comment.
Is Box needed because Javascript? 😅
There was a problem hiding this comment.
No, clippy yells becuse that variant is 240 bytes long (pretty long for an enum). Setting it as a box just uses a pointer instead.
| "neon-cli": "^0.3.3", | ||
| "neon-cli": "^0.9.1", |
There was a problem hiding this comment.
npm audit --fix did it !
|
I will merge this so we can rebase other PRs. @n1t0 we can still discuss some choices here.
|
McPatate
pushed a commit
that referenced
this pull request
Dec 15, 2021
* Clippy fixes. * Drop support for Python 3.6 * Remove other 3.6 * Re-enabling caches for build (5h + seems too long and issue seems solved) actions/runner-images#572 * `npm audit fix`. * Fix yaml ? * Pyarrow issue fixed: huggingface/datasets#2268 * Installing dev libraries. * Install python dev elsewhere ? * Typo. * No sudo. * ... * Testing the GH again. * Maybe v2 will fix ? * Fixing tests on MacOS Python 3.8+
McPatate
pushed a commit
that referenced
this pull request
Dec 22, 2021
* Clippy fixes. * Drop support for Python 3.6 * Remove other 3.6 * Re-enabling caches for build (5h + seems too long and issue seems solved) actions/runner-images#572 * `npm audit fix`. * Fix yaml ? * Pyarrow issue fixed: huggingface/datasets#2268 * Installing dev libraries. * Install python dev elsewhere ? * Typo. * No sudo. * ... * Testing the GH again. * Maybe v2 will fix ? * Fixing tests on MacOS Python 3.8+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing all new clippy warnings.