Automatic Formatting with apple/swift-format
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I've been waiting. |
|
Thank you, this was surely needed! I'll review in depth soon. Would you say that the rules you chose are more or less standard across Swift codebases, or are there other alternatives? (I personally don't like to break up all function parameters in multiple lines, but willing to sacrifice for consistency). |
|
Not sure the standard exists in Swift. I'm now enabling these rules in the libraries I maintain - UForm, USearch, StringZilla. Maybe with enough popular libraries agreeing on the format, we can propose that missing standard 🤷♂️ |
|
Xcode 16 has a built-in apple/swift-format https://www.reddit.com/r/iOSProgramming/comments/1df0ooe/xcode_16_now_has_a_builtin_formatter/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with the repository, I am not always sure about how to style code, as Swift gives a lot of flexibility on where to put
publicclauses, how to indent the code and so on. Moreover, Xcode isn't friendly to "Format on Save". Luckily, there is aswift-formatutility from Apple, that works very similar toclang-format.We extensively use such systems in our codebases. They help keep the code sane when the number of contributors rises. If interested, you may want to add it to your Git hooks.