feat!: added null support to spm_precompiled #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds null support to
spm_precompiled
based on huggingface/tokenizers#1627also made some changes to test.rs to move the big binary and json into separate files.
This pull request includes changes to enhance the handling of optional precompiled character maps in the
Precompiled
struct. The most important changes involve modifying the serialization and deserialization methods, updating the struct definitions, and adjusting the implementation of thefrom
method.Handling Optional Precompiled Character Maps:
src/lib.rs
: Changedprecompiled_charsmap
fromVec<u8>
toOption<Vec<u8>>
in bothPrecompiled
andPrecompiledDeserializer
structs. [1] [2]src/lib.rs
: Updatedas_base64
andfrom_base64
functions to handleOption<T>
types, ensuring proper serialization and deserialization of optional values.src/lib.rs
: Modified thefrom
method in thePrecompiled
implementation to handleOption<&[u8]>
, providing a default value whenNone
is encountered.