-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests
] Resolve remaining test failures
#550
Merged
tomaarsen
merged 21 commits into
huggingface:main
from
tomaarsen:tests/resolve-breaks-due-to-deps
Sep 12, 2024
Merged
[tests
] Resolve remaining test failures
#550
tomaarsen
merged 21 commits into
huggingface:main
from
tomaarsen:tests/resolve-breaks-due-to-deps
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And it fails because the log doesn't get captured by the test, not because the log isn't thrown
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
These proved problematic as the ordering of each section in the metadata can change between OSes, versions, etc.
Previously, these would fail for various reasons
…o==2022.3.0 Skipping it allows us to add tests for Python 3.11 and 3.12, and OpenVINO support is not as important to SetFit as having tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
huggingface-hub
model_id
inmodel_card_data
if it's not already setDetails
This PR aims to solve the outstanding issues that have built up due to updated dependencies, etc.