Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Resolve remaining test failures #550

Merged
merged 21 commits into from
Sep 12, 2024

Conversation

tomaarsen
Copy link
Member

Hello!

Pull Request overview

  • Avoid onnx==1.16.2 due to errors on Windows
  • Skip a flaky tests that only fails when running the full test suite; fails due to log not being captured by the test suite
  • Fix a model card pattern due to changes in huggingface-hub
  • Only override model_id in model_card_data if it's not already set

Details

This PR aims to solve the outstanding issues that have built up due to updated dependencies, etc.

  • Tom Aarsen

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tomaarsen tomaarsen merged commit 72f4d1e into huggingface:main Sep 12, 2024
22 checks passed
@tomaarsen tomaarsen deleted the tests/resolve-breaks-due-to-deps branch September 12, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants