Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] enable test_vera_dtypes on XPU #2017

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Aug 19, 2024

Hi, this PR enables the BF16 test on XPU. Below is the result after fix:

pytest -rA tests/test_vera.py::TestVera::test_vera_dtypes[dtype2]
================================================= short test summary info ==================================================
PASSED tests/test_vera.py::TestVera::test_vera_dtypes[dtype2]
=============================================== 1 passed, 1 warning in 4.63s ===============================================

@faaany faaany marked this pull request as draft August 19, 2024 10:22
@faaany faaany changed the title [tests] enable on XPU [tests] enable test_vera_dtypes on XPU Aug 19, 2024
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR to enable the test on XPU. I take it that XPU always supports bf16? I don't have a means to check that.

I made a suggestion to improve the readability of the test, otherwise LGTM.

tests/test_vera.py Outdated Show resolved Hide resolved
@faaany faaany marked this pull request as ready for review August 19, 2024 14:28
@faaany
Copy link
Contributor Author

faaany commented Aug 19, 2024

done~

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@faaany
Copy link
Contributor Author

faaany commented Aug 20, 2024

I think this failed test is not related to my PR. Could you help retrigger the CI? Thx! @BenjaminBossan

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of testing on XPU, LGTM.

@BenjaminBossan BenjaminBossan merged commit eb5eb6e into huggingface:main Aug 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants