Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Import error in BOFT half precision test #1995

Merged

Conversation

BenjaminBossan
Copy link
Member

@BenjaminBossan BenjaminBossan commented Aug 8, 2024

There was a small last minute change in #1925 that broke the tests. It should be boft.layer.Linear and not boft.Linear. As these are GPU tests, CI didn't catch this and I did not run this locally to verify.

@BenjaminBossan
Copy link
Member Author

FYI @Edenzzzz the nightly tests on GPU failed, this should fix them.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Maybe in the future we could do:
https://github.com/huggingface/diffusers/blob/main/.github/workflows/run_tests_from_a_pr.yml

This will allow us to trigger desired tests on the GPU runner.

@BenjaminBossan
Copy link
Member Author

Thanks. Maybe in the future we could do: https://github.com/huggingface/diffusers/blob/main/.github/workflows/run_tests_from_a_pr.yml

This will allow us to trigger desired tests on the GPU runner.

Normally I test GPU tests locally but as this was a late change, I forgot to re-run the tests, so it was just a personal oversight.

@BenjaminBossan BenjaminBossan merged commit 41c274e into huggingface:main Aug 8, 2024
14 checks passed
@BenjaminBossan BenjaminBossan deleted the fix-test-import-boft branch August 8, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants