FIX TEST: Higher tolerance for AdaLoRA in test #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is flaky on CI, so this PR increases the tolerance to hopefully fix the flakines. I cannot reproduce the error locally (neither on GPU nor CPU), so I'm not 100% sure if this tolerance is enough to make the test reliable.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Let's hope this fixes it. Using this decorator could be a last resort if we don't find a better way. |
BenjaminBossan
added a commit
to BenjaminBossan/peft
that referenced
this pull request
Jul 1, 2024
See huggingface#1897 for more context. The test is still flaky, increasing tolerance further.
BenjaminBossan
added a commit
that referenced
this pull request
Jul 2, 2024
See #1897 for more context. The test is still flaky, increasing tolerance further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is flaky on CI, so this PR increases the tolerance to hopefully fix the flakines. I cannot reproduce the error locally (neither on GPU nor CPU), so I'm not 100% sure if this tolerance is enough to make the test reliable.