FIX Failing Llama tests due to new kv cache #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires to install transformers from source (so normal CI won't pick this up). To replicate, run these tests: pytest tests/test_multitask_prompt_tuning.py pytest tests/test_decoder_models.py -k "test_trl_internal_testing_tiny_random_LlamaForCausalLM and (prefix or prompt) and (generate or disable)" This should result in 17 failing tests. The issue is that past_key_values can now be an instance of DynamicCache. Therefore, just indexing into it won't work anymore. The solution is to check the type and if it's not a tuple, use the methods on the cache object instead.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Jun 6, 2024
BenjaminBossan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires to install transformers from source (so normal CI won't pick this up).
To replicate, run these tests:
This should result in 17 failing tests.
The issue is that
past_key_valuescan now be an instance ofDynamicCache. Therefore, just indexing into it won't work anymore. The solution is to check the type and if it's not a tuple, use the methods on the cache object instead.