-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply deprecated evaluation_strategy
#1664
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
eval_strategy
evaluation_strategy
Hmm, but this means that any older transformers version would result in an error, would it not? If we merge this PR, everyone trying to use those examples needs to upgrade to the latest transformers just to avoid getting a deprecation message. I think this is not worthwhile. Ideally, we can revisit this PR in 6-12 months, when we can be reasonably sure that most users have moved to a new transformers version, or once transformers v4.46 is slated to be released. |
@BenjaminBossan will go live in v4.41.0 and stay until 4.46.0 as detailed in the thread (6 months) |
And yes, this PR is open for the future :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @muellerzr, for updating the examples!
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! This shouldn't go stale right?
I'm still withholding review to wait for
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
@muellerzr Has the time come now? |
@BenjaminBossan yes, time has come :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this deprecation in the PEFT examples and docs. I tested this on one notebook and the changes indeed remove the deprecation warning. LGTM.
In docs and examples, use eval_strategy instead of evaluation_strategy, which is deprecated.
This PR applies the deprecated
evaluation_strategy
from huggingface/transformers#30190.TL;DR:
evaluation_strategy
->eval_strategy
(Should go live in v4.41.0, but opening now so it's here when ready!)