Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply deprecated evaluation_strategy #1664

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

muellerzr
Copy link
Contributor

@muellerzr muellerzr commented Apr 18, 2024

This PR applies the deprecated evaluation_strategy from huggingface/transformers#30190.

TL;DR: evaluation_strategy -> eval_strategy

(Should go live in v4.41.0, but opening now so it's here when ready!)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr muellerzr changed the title Apply deprecated eval_strategy Apply deprecated evaluation_strategy Apr 18, 2024
@BenjaminBossan
Copy link
Member

Hmm, but this means that any older transformers version would result in an error, would it not? If we merge this PR, everyone trying to use those examples needs to upgrade to the latest transformers just to avoid getting a deprecation message. I think this is not worthwhile.

Ideally, we can revisit this PR in 6-12 months, when we can be reasonably sure that most users have moved to a new transformers version, or once transformers v4.46 is slated to be released.

@muellerzr
Copy link
Contributor Author

@BenjaminBossan will go live in v4.41.0 and stay until 4.46.0 as detailed in the thread (6 months)

@muellerzr
Copy link
Contributor Author

And yes, this PR is open for the future :)

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @muellerzr, for updating the examples!

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! This shouldn't go stale right?

@BenjaminBossan
Copy link
Member

I'm still withholding review to wait for

will go live in v4.41.0 and stay until 4.46.0 as detailed in the thread (6 months)

Copy link

github-actions bot commented Jul 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

@github-actions github-actions bot closed this Jul 15, 2024
@github-actions github-actions bot closed this Jul 24, 2024
@github-actions github-actions bot closed this Aug 2, 2024
@BenjaminBossan BenjaminBossan reopened this Aug 2, 2024
@github-actions github-actions bot closed this Aug 11, 2024
@github-actions github-actions bot closed this Aug 20, 2024
@muellerzr muellerzr reopened this Aug 20, 2024
@github-actions github-actions bot closed this Sep 13, 2024
@BenjaminBossan
Copy link
Member

@muellerzr Has the time come now?

@muellerzr
Copy link
Contributor Author

@BenjaminBossan yes, time has come :)

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this deprecation in the PEFT examples and docs. I tested this on one notebook and the changes indeed remove the deprecation warning. LGTM.

@BenjaminBossan BenjaminBossan merged commit 18f3efe into main Sep 13, 2024
72 of 76 checks passed
BenjaminBossan pushed a commit to BenjaminBossan/peft that referenced this pull request Sep 18, 2024
In docs and examples, use eval_strategy instead of evaluation_strategy, which is
deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants