Don't use deprecated Repository anymore
#1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2024
younesbelkada
approved these changes
Apr 12, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
It was actually more than just linting! 😬 |
|
Thanks for the reviews! |
DTennant
pushed a commit
to DTennant/peft
that referenced
this pull request
Apr 16, 2024
* Don't use deprecated Repository anymore * oops
DTennant
pushed a commit
to DTennant/peft
that referenced
this pull request
Apr 19, 2024
* Don't use deprecated Repository anymore * oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repositoryis a deprecated feature inhuggingface_hub. It is more robust to use the HTTP-based methods fromHfApiinstead. Here is a doc page explaining why it's better. Main reasons are 1. don't need to clone a repo to push files 2. faster upload speed 3. don't need git/git+lfs configured locally.transformersswitched to useHfApiis all their training scripts in Aug 23' (see huggingface/transformers#25095) without breaking. Let's do the same forpeft!I also removed the
get_full_repo_nameredefinition, in favor ofcreate_repo(repo_name, exists_ok=Ture).repo_id=> no need to infer the explicit repo_id before creating_it.Disclaimer: I did not test those changes myself. Should be fine though.
Similar PRs: huggingface/accelerate#2658 huggingface/parler-tts#18