FIX Correctly call element_size #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix the error introduced by huggingface#1630. AFAICT, element_size should be called on the parameter, not the dtype. Unfortunately, I had issues getting older PyTorch versions to work with bnb, so I haven't tested the initial issue. To be safe, I also re-added the previous code path using itemsize, although it might be unnecessary (we would have to check the PyTorch code to verify when the different attributes/methods were added).
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Ping @winglian if you could please check if this PR still resolves your initial issue. |
younesbelkada
approved these changes
Apr 9, 2024
|
@BenjaminBossan yup, this works for me. thanks! |
This was referenced Apr 10, 2024
DTennant
pushed a commit
to DTennant/peft
that referenced
this pull request
Apr 16, 2024
Should fix the error introduced by huggingface#1630. AFAICT, element_size should be called on the parameter, not the dtype. Unfortunately, I had issues getting older PyTorch versions to work with bnb, so I haven't tested the initial issue. To be safe, I also re-added the previous code path using itemsize, although it might be unnecessary (we would have to check the PyTorch code to verify when the different attributes/methods were added).
Closed
4 tasks
DTennant
pushed a commit
to DTennant/peft
that referenced
this pull request
Apr 19, 2024
Should fix the error introduced by huggingface#1630. AFAICT, element_size should be called on the parameter, not the dtype. Unfortunately, I had issues getting older PyTorch versions to work with bnb, so I haven't tested the initial issue. To be safe, I also re-added the previous code path using itemsize, although it might be unnecessary (we would have to check the PyTorch code to verify when the different attributes/methods were added).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the error introduced by #1630.
AFAICT,
element_sizeshould be called on the parameter, not thedtype. Unfortunately, I had issues getting older PyTorch versions to work with bnb, so I haven't tested the initial issue.To be safe, I also re-added the previous code path using
itemsize, although it might be unnecessary (we would have to check the PyTorch code to verify when the different attributes/methods were added).