Adalora deepspeed #1625
Merged
Adalora deepspeed #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sywangyi
force-pushed
the
adalora_deepspeed
branch
from
d297a96
to
6ed60f7
Compare
There was a problem hiding this comment.
Thanks a lot, these changes make sense. I have some minor comments but no real blockers. Also pinging @pacman100 as our DS expert.
sywangyi
force-pushed
the
adalora_deepspeed
branch
from
6ed60f7
to
68fac81
Compare
3 tasks
Signed-off-by: Wang, Yi A <[email protected]>
sywangyi
force-pushed
the
adalora_deepspeed
branch
from
68fac81
to
513ca8d
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Apr 9, 2024
DTennant
pushed a commit
to DTennant/peft
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Wang, Yi A <[email protected]>
DTennant
pushed a commit
to DTennant/peft
that referenced
this pull request
Apr 19, 2024
Signed-off-by: Wang, Yi A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix crash when enable deepspeed zero3 + adalora