Raise error on wrong type for to modules_to_save #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves huggingface#1492 This PR is for user convenience. When they try to pass the wrong type to modules_to_save, they will now get an early error message, instead of getting an obscure error when calling forward later. Note: The reason why ModulesToSaveWrapper cannot support ModuleDict et al. is because it tries to call forward on the original or copied module, but these modules don't implement a forward method.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Feb 21, 2024
BenjaminBossan
deleted the
raise-error-when-modules_to_save-wrong-type
branch
BenjaminBossan
added a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
Resolves huggingface#1492 This PR is for user convenience. When they try to pass the wrong type to modules_to_save, they will now get an early error message, instead of getting an obscure error when calling forward later. Note: The reason why ModulesToSaveWrapper cannot support ModuleDict et al. is because it tries to call forward on the original or copied module, but these modules don't implement a forward method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1492
This PR is for user convenience. When they try to pass the wrong type to
modules_to_save, they will now get an early error message, instead of getting an obscure error when callingforwardlater.Note:
The reason why
ModulesToSaveWrappercannot supportModuleDictet al. is because it tries to call forward on the original or copied module, but these modules don't implement aforwardmethod.