Add pre-commit configuration #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Thanks ! In principle I am ok with this PR as we have it on other libs as well, e.g. TRL !
I would like to hear what @BenjaminBossan & @pacman100 think, I agree pre-commit is quite convenient
|
I had some issues with pre-commit in the past. Some probably won't apply here (e.g. it being slow) but in the end, everyone is free to choose if they want to activate them or not, so I see no real harm (there is a small maintenance cost of keeping the config in sync). |
BenjaminBossan
approved these changes
Feb 16, 2024
younesbelkada
approved these changes
Feb 18, 2024
BenjaminBossan
pushed a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a pre-commit configuration, so developers may opt in to running
ruffandruff-formatas a pre-commit hook.Should reduce the need for "fix lint" commits and
check_code_qualityCI failures.Sibling of huggingface/accelerate#2451