add magnitude_prune merging method
#1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Thanks for adding this new adapter merging method. Implementation-wise, this LGTM. Since your experiments show that it works well, it's a great addition.
Let's ensure that it is documented by updating the docs added via #1423, depending on which PR lands first.
Also, as mentioned in a previous PR, it would be good to add unit tests for merge_utils.py eventually.
BenjaminBossan
pushed a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
* add `magnitude_prune` merging method * Update model.py * 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
magnitude_prunewhich first prunes the task tensors to remove small values and retain top_k values based on the paramdensity. After this, a weighted sum is computed and returned.