Use plain asserts in tests #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As Zach mentioned, we'll have an internal discussion first to ensure that we have consensus, as we want the HF code bases to be consistent when it comes to the testing style (we know they're not completely consistent right now, but mostly). |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Could you please run |
|
@BenjaminBossan Rebased, reformatted. |
|
@akx There are some instances of |
akx
force-pushed
the
codemod-pytest
branch
5 times, most recently
from
813fc25
to
861566e
Compare
akx
force-pushed
the
codemod-pytest
branch
2 times, most recently
from
9ec3e07
to
1003c39
Compare
BenjaminBossan
approved these changes
Feb 14, 2024
BenjaminBossan
pushed a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
Use pytest style asserts instead of unittest methods. Use `pytest.raises` and `pytest.warns` where suitable.
BenjaminBossan
pushed a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
Use pytest style asserts instead of unittest methods. Use `pytest.raises` and `pytest.warns` where suitable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain assertions are easier to debug than Unittest
self.assert*s due to Pytest's assertion rewriting.Similar to huggingface/accelerate#2420, this was done via codemod-unittest-to-pytest-asserts and
ast-grep.Sibling of huggingface/trl#1301.