Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix critical bug in diffusers #1427

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Feb 1, 2024

Fixes huggingface/diffusers#6809

Indeeed copy does not exist in PyTorch 🤯 one needs to use clone() .. that code path was never tested so I added some CI tests for that so that it'll never happen in the future

cc @pacman100 @apolinario

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Younes for the quick fixes and nice test! ⚡

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada merged commit a30e006 into huggingface:main Feb 1, 2024
14 checks passed
@younesbelkada younesbelkada deleted the fix-diffusers-lora branch February 1, 2024 12:21
BenjaminBossan pushed a commit to BenjaminBossan/peft that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some LoRA adapters cannot load anymore when using PEFT library under the hood
3 participants